Repository navigation
Fix opcache phar check - #25128
Closed
ndossche wants to merge 1 commit into
Closed
Fix opcache phar check#25128ndossche wants to merge 1 commit into
ndossche wants to merge 1 commit into
Conversation
This is the cause of the flaky nightly failures on PPC for `issue0149.phpt`. On slow machines, enough time passes that request 2/3 are served from opcache rather than from the disk. If we set `opcache.file_update_protection=0`, then the failure reproduces predictably. The root cause is that the phar check in opcache only checks if the filename ends in `.phar` whereas ext/phar checks whether `.phar` is anywhere in the filename. This difference causes requests from the cache to not execute the stub, and therefore not execute the `Phar::mount()` call in the test, and therefore fail the expectation.
iliaal
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the cause of the flaky nightly failures on PPC for
issue0149.phpt. On slow machines, enough time passes that request 2/3 are served from opcache rather than from the disk.If we set
opcache.file_update_protection=0, then the failure reproduces predictably.The root cause is that the phar check in opcache only checks if the filename ends in
.pharwhereas ext/phar checks whether.pharis anywhere in the filename. This difference causes requests from the cache to not execute the stub, and therefore not execute thePhar::mount()call in the test, and therefore fail the expectation.